gitlab-ci.yml refactoring v1 #7988
Conversation
add i386,arm64,armv7 snap packages & snap release added a protect variable for protected branches and tags rustfmt&clippy tests (they are necessary to us?) changes in a caching retry job for centos #if version `GLIBC_2.18' not found anchors in gitlab-ci.yml
General-Beck
added
A0-pleasereview 🤓
| @@ -1,197 +1,152 @@ | |||
| stages: | |||
| - test | |||
| - push-release | |||
There was a problem hiding this comment.
I think this should stay. It notifies upater about new version (not specific build)
.gitlab-ci.yml
Outdated
| - beta | ||
| - gitlab |
There was a problem hiding this comment.
That's a testing branch, right?
.gitlab-ci.yml
Outdated
| .artifacts_rules: &artifacts_rules | ||
| artifacts: | ||
| when: on_success | ||
| expire_in: 1 mos |
There was a problem hiding this comment.
Actually might be better to just keep fixed number of artifacts (i.e. might be good to download old stable binaries even after a month).
There was a problem hiding this comment.
we have them in S3 and vanity
.gitlab-ci.yml
Outdated
| script: | ||
| - scripts/gitlab-build.sh armv7-unknown-linux-gnueabihf armv7-unknown-linux-gnueabihf armhf arm-linux-gnueabihf-gcc arm-linux-gnueabihf-g++ ubuntu | ||
| tags: | ||
| - rust-arm | ||
| artifacts: | ||
| paths: | ||
| - parity.zip | ||
| - artifacts/ | ||
| expire_in: 1 mos |
There was a problem hiding this comment.
same here, I think would be better to keep fixed number of artifacts instead.
There was a problem hiding this comment.
no, we have a difference in quantity
https://gitlab.parity.io/parity/parity/-/jobs/80231/artifacts/browse/artifacts/ arm64 snap
https://gitlab.parity.io/parity/parity/-/jobs/80228/artifacts/browse/artifacts/ arm64 deb
| set -e # fail on any error | ||
| set -u # treat unset variables as error |
There was a problem hiding this comment.
Imho was pretty useful. Maybe set $protected to some default value in an if statement?
There was a problem hiding this comment.
temporary solution
There was a problem hiding this comment.
to what? can you elaborate?
| make_archive | ||
| push_binaries | ||
| echo "__________Use libssl1.1 (>=1.1.0) for Debian builds__________" | ||
| build_and_push |
There was a problem hiding this comment.
This changes the behaviour since we are pushing to auto-updater as well. Right now auto-updater is smart enough to reject such request (if the PLATFORM is set correctly). Although I think it would be good to avoid pushing to auto-updater if we know it's gonna be rejected (i.e. we only care about darwin, linux and windows packages).
| push_binaries | ||
| updater_push_release |
There was a problem hiding this comment.
Same, we don't care about centos for auto-updating.
| make_snap | ||
| ;; | ||
| i686-unknown-snap-gnu) | ||
| set_env |
There was a problem hiding this comment.
We do we need set_env here but not for other snaps? Do we actually care about that at all?
There was a problem hiding this comment.
in this case it is necessary
scripts/gitlab-test.sh
Outdated
| @@ -44,4 +44,12 @@ case $TEST_SWITCH in | |||
| test-coverage) | |||
| coverage_test | |||
| ;; | |||
| rustfmt) | |||
| cargo install rustfmt-nightly | |||
There was a problem hiding this comment.
we don't really have a good config for rustfmt yet, don't think it's needed.
scripts/gitlab-test.sh
Outdated
| ;; | ||
| clippy) | ||
| cargo install clippy | ||
| cargo clippy -- -D warnings |
There was a problem hiding this comment.
same here, right now it will fail with millions of errors, since we don't use it. I think it would be better to first fix the codebase and then introduce this.
There was a problem hiding this comment.
it is necessary to add in TODO
5chdn
added
the
P2-asap 🌊
* Regular names of tasks; better includes * Split gitlab test scripts into separate files * [WIP] Reuse artifacts for docker builds * Refactored snapcraft building significantely * [WIP] Separate build scripts * Regularize architectures * Builds on Windows
|
@General-Beck please address unanswered questions |
|
@debris all work now here. It is a lot of changes, but I will finish soon. https://gitlab.parity.io/parity/parity/tree/gitlab |
5chdn
added
A1-onice 🌨
|
please reopen when it's updated |
add i386,arm64,armv7 snap packages & snap release
added a protect variable for protected branches and tags
rustfmt&clippy tests (they are necessary to us?)
changes in a caching
retry job for centos #if version `GLIBC_2.18' not found
anchors in gitlab-ci.yml