This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andresilva
commented
Mar 16, 2018
•
edited
Loading
edited
andresilva
added
A0-pleasereview 🤓
Pull request needs code review.
M4-core ⛓
Core client code / Rust.
labels
Mar 16, 2018
andresilva
changed the title
ethcore: postpone Kovan hard fork
Postpone Kovan hard fork
Mar 16, 2018
tomusdrw
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Mar 16, 2018
tomusdrw
approved these changes
Mar 16, 2018
Can we also update fork number in |
andresilva
commented
Mar 17, 2018
@@ -13,13 +13,13 @@ build = "build.rs" | |||
track = "nightly" | |||
|
|||
# Indicates a critical release in this track (i.e. consensus issue) | |||
critical = false | |||
critical = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do we switch this back to false
afterwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a bit unclear for me as well :)
I suppose we should flip it back when bumping new version, but clients updating from say 1.x.N to 1.x.(N+2) should still consider that critical, even though N+2
is not. I don't think that logic is implemented in the updater currently, but don't consider that a blocker.
debris
approved these changes
Mar 19, 2018
NikVolf
approved these changes
Mar 19, 2018
tomusdrw
pushed a commit
that referenced
this pull request
Mar 19, 2018
* ethcore: postpone Kovan hard fork * util: update version fork metadata
andresilva
added a commit
that referenced
this pull request
Mar 19, 2018
* ethcore: postpone Kovan hard fork * util: update version fork metadata
General-Beck
added a commit
that referenced
this pull request
Mar 19, 2018
This reverts commit a7887fa.
andresilva
added a commit
that referenced
this pull request
Mar 19, 2018
* ethcore: postpone Kovan hard fork * util: update version fork metadata
andresilva
pushed a commit
that referenced
this pull request
Mar 19, 2018
* Postpone Kovan hard fork (#8137) * ethcore: postpone Kovan hard fork * util: update version fork metadata * WASM libraries bump (#7970) * update wasmi, parity-wasm, wasm-utils to latest version * Update to new wasmi & error handling * also utilize new stack limiter * fix typo * replace dependency url * Cargo.lock update
tomusdrw
pushed a commit
that referenced
this pull request
Mar 19, 2018
* Support parity protocol. (#8035) * updater: apply exponential backoff after download failure (#8059) * updater: apply exponential backoff after download failure * updater: reset backoff on new release * Max code size on Kovan (#8067) * Enable code size limit on kovan * Fix formatting. * Limit incoming connections. (#8060) * Limit ingress connections * Optimized handshakes logging * WASM libraries bump (#7970) * update wasmi, parity-wasm, wasm-utils to latest version * Update to new wasmi & error handling * also utilize new stack limiter * fix typo * replace dependency url * Cargo.lock update * add some dos protection (#8084) * revert removing blooms (#8066) * Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167" This reverts commit 1bf6203. * Revert "fixed broken logs (#7934)" This reverts commit f8a2e53. * fixed broken logs * bring back old lock order * remove migration v13 * revert CURRENT_VERSION to 12 in migration.rs * more dos protection (#8104) * Const time comparison (#8113) * Use `subtle::slices_equal` for constant time comparison. Also update the existing version of subtle in `ethcrypto` from 0.1 to 0.5 * Test specifically for InvalidPassword error. * fix trace filter returning returning unrelated reward calls, closes #8070 (#8098) * network: init discovery using healthy nodes (#8061) * network: init discovery using healthy nodes * network: fix style grumble * network: fix typo * Postpone Kovan hard fork (#8137) * ethcore: postpone Kovan hard fork * util: update version fork metadata * Disable UI by default. (#8105) * dapps: update parity-ui dependencies (#8160)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.