This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Error message when sync is still in progress. #9475
Merged
+489
−210
Merged
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
354c9c8
closes #9188
seunlanlege 37100e0
check_for_unavailable_block in
seunlanlege 2929c70
check for unavailable block in eth_getBlockByNumber
seunlanlege b788be4
corrected checks for unavailable_block
seunlanlege 1d31e11
check for block gaps in db
seunlanlege 32872ea
corrected error messages
seunlanlege 7f73e25
corrected error information
seunlanlege de99ded
added allow-empty-block-result cli flag
seunlanlege efce6d5
address grumbles
andresilva a60eb7e
--jsonrpc-allow-missing-blocks
seunlanlege eddab46
fix tests
seunlanlege 9702290
Merge branch 'master' into issue-9188
5chdn 430cebd
added checks to
seunlanlege 251be48
Update parity/cli/mod.rs
sorpaas 154751c
Update parity/cli/mod.rs
sorpaas 5b3b60e
Apply suggestions from code review
sorpaas 85f7612
fix PR grumbles
seunlanlege 6ba18ad
Merge branch 'issue-9188' of github.com:paritytech/parity-ethereum in…
seunlanlege 162aa49
fix more PR grumbles
seunlanlege File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe name this just
allow_missing_blocks
? We need thejsonrpc
prefix for args but they're already under the category for configs.