This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Backport Stable 2.1.6 #9904
Merged
Backport Stable 2.1.6 #9904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tbaut
commented
Nov 13, 2018
•
Tbaut
commented
- Bump version
- fix: Intermittent failing CI due to addr in use fix: Intermittent failing CI due to addr in use #9885
- Add hardcoded headers for light client Update hardcoded headers #9907
- gitlab-ci: make android release build succeed gitlab-ci: make android release build succeed #9743
- light-fetch: Differentiate between out-of-gas/manual throw and use required gas from response on failure light-fetch: Differentiate between out-of-gas/manual throw and use required gas from response on failure #9824
- Remove rust-toolchain file Remove rust-toolchain file #9906
- simplify cargo audit simplify cargo audit #9918
- ci: nuke the gitlab caches ci: nuke the gitlab caches #9855
Tbaut
added
A8-backport 🕸
* ethcore: use Machine::verify_transaction on parent block also fixes off-by-one activation of transaction permission contract * ethcore: clarify call to verify_transaction
Allow OS to set port at runtime
* use docker cargo config file for android builds * make android build succeed
sorpaas
approved these changes
Nov 13, 2018
…quired gas from response on failure (#9824) * fix start_gas, handle OOG exceptions & NotEnoughGas * Change START_GAS: 50_000 -> 60_000 * When the `OutOfGas exception` is received then try to double the gas until it succeeds or block gas limit is reached * When `NotEnoughBasGas error` is received then use the required gas provided in the response * fix(light-fetch): ensure block_gas_limit is tried Try the `block_gas_limit` before regard the execution as an error * Update rpc/src/v1/helpers/light_fetch.rs Co-Authored-By: niklasad1 <[email protected]>
ordian
previously approved these changes
Nov 14, 2018
ordian
force-pushed
the
Tbaut-stable-216
branch
from
e36c89a to
dc7623a
Compare
seunlanlege
force-pushed
the
Tbaut-stable-216
branch
from
dfa6a3c to
dc7623a
Compare
ordian
approved these changes
Nov 14, 2018
ordian
added
A8-looksgood 🦄
Will go without cache. Meanwhile have to investigate what was wrong and how to use it effectively.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.