Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Unbreak parity-rpc build on rust -stable #9934

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Conversation

reyk
Copy link
Contributor

@reyk reyk commented Nov 17, 2018

   Compiling parity-rpc v1.12.0 (file:///home/reyk/devel/parity-ethereum/rpc)
error[E0658]: access to extern crates through prelude is experimental (see issue #44660)
   --> rpc/src/v1/helpers/light_fetch.rs:628:19
    |
628 |                         if let Some(vm::Error::OutOfGas) = executed.exception {
    |                                     ^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.
error: Could not compile `parity-rpc`.

@parity-cla-bot
Copy link

It looks like @reyk hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@reyk
Copy link
Contributor Author

reyk commented Nov 17, 2018

[clabot:check]

@parity-cla-bot
Copy link

It looks like @reyk signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@niklasad1
Copy link
Collaborator

Hey, thanks but it works on Rust stable 1.30. Please update your toolchain instead

@reyk
Copy link
Contributor Author

reyk commented Nov 17, 2018

It's a simple fix that works on both versions, what speaks against merging it?

I'm using OpenBSD 6.4 that ships rust 1.29.2 - OpenBSD -current includes 1.30.x or later but the next OpenBSD -stable release (6.5) will only be released in about 6 months.

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Nov 17, 2018
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, didn't know that about OpenBSD!

Looks good, but we can't guarantee that we won't break it because rust 1.30 has some nice new features!

@tomusdrw tomusdrw merged commit c0952ba into openethereum:master Nov 17, 2018
@tomusdrw tomusdrw removed the A0-pleasereview 🤓 Pull request needs code review. label Nov 17, 2018
@reyk reyk deleted the reyk/rpc branch November 20, 2018 11:51
@reyk
Copy link
Contributor Author

reyk commented Nov 20, 2018

Thanks!

@5chdn 5chdn added this to the 2.3 milestone Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants