-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENEUROPA-575: Create composer plugin for using release artifacts #1
Conversation
tests/fixtures/composerProvider.yml
Outdated
existing: | ||
- /vendor/openeuropa/dependency-1/composer.json | ||
- /vendor/openeuropa/dependency-2/composer.json | ||
- /vendor/openeuropa/dependency-1/artifact.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is wrong, artifact should not be existing if launched with --prefer-source
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by adding a comment in the .yml file.
…e investigation in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tested using oe_profile to build oe_theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After peer coding session with @ademarco , it's approved! \o/
Issue #1: Add .editorconfig file.
No description provided.