Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENEUROPA-575: Create composer plugin for using release artifacts #1

Merged
merged 24 commits into from
May 28, 2018

Conversation

ademarco
Copy link
Member

No description provided.

existing:
- /vendor/openeuropa/dependency-1/composer.json
- /vendor/openeuropa/dependency-2/composer.json
- /vendor/openeuropa/dependency-1/artifact.txt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is wrong, artifact should not be existing if launched with --prefer-source.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by adding a comment in the .yml file.

Copy link

@richardcanoe richardcanoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Tested using oe_profile to build oe_theme.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After peer coding session with @ademarco , it's approved! \o/

@drupol drupol merged commit cecf7fc into master May 28, 2018
@drupol drupol deleted the OPENEUROPA-575 branch May 28, 2018 15:06
drupol added a commit that referenced this pull request Jun 29, 2018
drupol pushed a commit that referenced this pull request Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants