Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Issue #33: Add vlucas/phpdotenv for local LAMP stack users. #34

Closed
wants to merge 1 commit into from

Conversation

vever001
Copy link

OPENEUROPA-???

Description

See #33

@vever001 vever001 changed the title Issue #33: Add vlucas/phpdotenv for LAMP stack users. Issue #33: Add vlucas/phpdotenv for local LAMP stack users. Aug 27, 2019
@vever001
Copy link
Author

@voidtek Could you have a look at this PR please?
thx

Copy link

@julien- julien- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being in LAMP profile, I had the issue that environment bash variables were not available in PHP. I tested this PR in my DEV environment and it works perfectly :

  • getenv() PHP function return the .env values so the settings.php is well provided. However it is a good idea to add the possibility to override this values with .env.local file.

@brummbar brummbar added the wontfix This will not be worked on label Sep 26, 2019
@brummbar
Copy link
Contributor

Hello @vever001 , we will always only support installations through Docker.

@brummbar brummbar closed this Sep 26, 2019
@vever001
Copy link
Author

This is truly sad to hear.
I understand docker can save some discussions/issues with environment setup but for people who know what they are doing this is a good addition and has minimal impact.

For those interested I created a fork here https://github.com/vever001/drupal-site-template that contains this PR and #37 as well as some other minor additions.
I will keep maintaining the fork and merge upstream changes, unless otherwise stated on the project page.

@gervasek
Copy link

gervasek commented Oct 1, 2019

Hello @vever001 , we will always only support installations through Docker.

Why? What is the problem to support lamp? The work is already done in this PR...

@brummbar
Copy link
Contributor

brummbar commented Jan 8, 2020

It was a technical decision of OpenEuropa. All OpenEuropa components are developed using Docker containers to mimic the IT infrastructure where they will be deployed (see here).
By using Docker, we cut down the "doesn't work on my machine" problems and the setup time for developers to start working/using components.
Components can of course be used without Docker, but we don't give support nor add functionalities to support that approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants