OPENEUROPA-1695: Implement footer block. Apply ECL component #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanoleguskiza
suggested changes
Mar 8, 2019
imanoleguskiza
previously approved these changes
Mar 11, 2019
ademarco
requested changes
Mar 11, 2019
| language switcher: ".ecl-language-list" | ||
| language switcher link: ".ecl-lang-select-sites__link .ecl-lang-select-sites__label" | ||
| language switcher overlay: ".ecl-dialog__body" | ||
| logo: "a.ecl-logo" | ||
| page header: ".ecl-page-header__body" | ||
| priorities dropdown menu: "#nav-menu-expandable-group-3 .ecl-navigation-menu__links" | ||
| search box: ".demo-block-header-search" |
There was a problem hiding this comment.
This seems to be out of scope, why are we removing it here?
There was a problem hiding this comment.
It looks like this PR missed attention: #176
So I did the same within this PR.
…making custom footer optional.
sergepavle
changed the title
sergepavle
force-pushed
the
OPENEUROPA-1695
branch
from
f62ab54 to
31cc465
Compare
sergepavle
force-pushed
the
OPENEUROPA-1695
branch
from
32a21f0 to
4170159
Compare
sergepavle
force-pushed
the
OPENEUROPA-1695
branch
4 times, most recently
from
6c255e9 to
76b6453
Compare
sergepavle
force-pushed
the
OPENEUROPA-1695
branch
from
76b6453 to
ea319b6
Compare
ademarco
requested changes
Mar 18, 2019
| * Theme override for the corporate block footer. | ||
| * | ||
| * Available variables: | ||
| * - content: rendered footer pattern. * |
There was a problem hiding this comment.
Small typo at end of line * - content: rendered footer pattern. *
| use Symfony\Component\DomCrawler\Crawler; | ||
|
|
||
| /** | ||
| * Class CorporateBlocksFooterTest. |
There was a problem hiding this comment.
Add meaningful class description.
| 'label_display' => '0', | ||
| ]; | ||
|
|
||
| $render = $this->buildBlock('oe_footer', $config); |
There was a problem hiding this comment.
We should override here the block footer configuration object by providing test configuration, so we can make sure that the template styled the footer correctly. I propose to have just 2 links per link category and test labels.
| $actual = $crawler->filter('footer.ecl-footer div.ecl-footer__corporate-top div.ecl-row div.ecl-footer__column'); | ||
| $this->assertCount(3, $actual); | ||
| $actual = $crawler->filter('footer.ecl-footer div.ecl-footer__corporate-bottom div.ecl-row ul.ecl-footer__list li.ecl-footer__list-item'); | ||
| $this->assertCount(7, $actual); |
There was a problem hiding this comment.
Following the comment above we should add here assertions that assert links and labels are styled correctly.
sergepavle
force-pushed
the
OPENEUROPA-1695
branch
from
68f02d3 to
c6ec15f
Compare
sergepavle
force-pushed
the
OPENEUROPA-1695
branch
from
c6ec15f to
2699544
Compare
ademarco
approved these changes
Mar 18, 2019
imanoleguskiza
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1695
Description
Change log
Commands