OPENEUROPA-1798: Page header content is not reflecting changes made before node is published #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernani
force-pushed
the
OPENEUROPA-1798
branch
from
f8e03ed to
53087b3
Compare
upchuk
requested changes
Apr 29, 2019
| ]; | ||
| $node = $this->getNode(); | ||
| if ($node->get('oe_summary')->isEmpty()) { | ||
| return $metadata; |
There was a problem hiding this comment.
This is not correct. Below we are also adding the news and publication date metas which do not have anything to do with the summary and would not be shown if the summary field is empty. So we cannot return early in this case.
| $supported = [ | ||
| 'entity.node.canonical', | ||
| 'entity.node.latest', | ||
| 'entity.node.revision', |
There was a problem hiding this comment.
It's missing the route: entity.node.latest_version. This is what users see as part of the editorial workflow. And I wonder if entity.node.latest actually exists anywhere?
There was a problem hiding this comment.
Yep I think entity.node.latest was a mistake of mine.
…ring functional tests.
… is covered by the base implementation.
…e view routes plugins.
brummbar
approved these changes
May 29, 2019
upchuk
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1798
Description
[Insert description here]
Change log
Commands