Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENEUROPA-2047: Add class for timeline to limit width. #278

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

nagyad
Copy link
Member

@nagyad nagyad commented Jul 24, 2019

image

@nagyad nagyad force-pushed the OPENEUROPA-2047 branch from cd38c9d to 95c6961 Compare July 24, 2019 12:52
Copy link
Member

@ademarco ademarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are wrapping everything around ecl-editor class as both title and long text field should be affected by that. This is not ideal but it will do the job, also considering that the ECL2 upgrade is coming soon.

@voidtek
Copy link
Member

voidtek commented Jul 24, 2019

The way to handle it is to add a <p class='ecl-paragraph'> for every item.

as we can see in the demo:

<div class="ecl-timeline__body">
  <p class="ecl-paragraph">
    Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer nec tellus congue, pretium nibh eu, mattis ligula. Integer tempus varius enim ut scelerisque. Curabitur rutrum vestibulum elit ac pulvinar.
  </p>
 </div>

Copy link
Member

@ademarco ademarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking with @brummbar we should not do this in the pattern but in the field template.

@nagyad nagyad force-pushed the OPENEUROPA-2047 branch from 95c6961 to 730d447 Compare July 24, 2019 13:25
@nagyad
Copy link
Member Author

nagyad commented Jul 24, 2019

@voidtek As Anto wrote, we need all elements to be wrapped, title, and body as well. If we would need to wrap individual items that we would need to patch ECL. Since ECLv2 is pending, I advise move as we did for Body and other fields, by wrapping it with ecl-editor class.

@nagyad nagyad force-pushed the OPENEUROPA-2047 branch from 730d447 to c664a0f Compare July 24, 2019 13:27
Copy link
Member

@ademarco ademarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this on the outside field template instead, it should be like field--....html.twig.

Copy link
Member

@ademarco ademarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After careful consideration we are back to square one. Approved.

@ademarco ademarco merged commit c1a04ba into master Jul 24, 2019
@ademarco ademarco deleted the OPENEUROPA-2047 branch July 29, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants