-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENEUROPA-2047: Add class for timeline to limit width. #278
Conversation
nagyad
commented
Jul 24, 2019
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are wrapping everything around ecl-editor
class as both title and long text field should be affected by that. This is not ideal but it will do the job, also considering that the ECL2 upgrade is coming soon.
The way to handle it is to add a as we can see in the demo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking with @brummbar we should not do this in the pattern but in the field template.
@voidtek As Anto wrote, we need all elements to be wrapped, title, and body as well. If we would need to wrap individual items that we would need to patch ECL. Since ECLv2 is pending, I advise move as we did for Body and other fields, by wrapping it with ecl-editor class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this on the outside field template instead, it should be like field--....html.twig
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After careful consideration we are back to square one. Approved.