feat(actions): add github workflows for test #58
Conversation
.github/workflows/test.yaml
Outdated
| uses: golangci/golangci-lint-action@v2 | ||
| with: | ||
| version: v1.29 | ||
| - name: test faas-swarm |
There was a problem hiding this comment.
Is it possible to split the setup, test, and tear down for swarm and faas-netes? If there are problems in the future it will be a little more clear why it failed.
As an example, the faas-netes worflow has individual steps https://github.com/openfaas/faas-netes/blob/master/.github/workflows/build.yaml
There was a problem hiding this comment.
thank you @LucasRoesler , done.
developer-guy
force-pushed
the
github-actions
branch
2 times, most recently
from
e315771 to
c1648c2
Compare
.github/workflows/test.yaml
Outdated
| OPENFAAS_URL: http://${{ env.IP }}:8080/ | ||
| - name: clean swarm cluster | ||
| run: ./contrib/clean_swarm_cluster.sh | ||
| - name: test faas-netes |
There was a problem hiding this comment.
followup to my previous comment, can we split the k8s setup too ?
There was a problem hiding this comment.
done. I updated the screenshot in the comment too.
developer-guy
force-pushed
the
github-actions
branch
3 times, most recently
from
a1c7a6f to
41d9b83
Compare
.github/workflows/test.yaml
Outdated
| IP: 127.0.0.1 | ||
|
|
||
| jobs: | ||
| test: |
There was a problem hiding this comment.
one last request, can we split it into two jobs test-swarm and test-k8s so that they can be run in parallel? it otherwise looks great
sorry, i didn't ask about it before i had to read the docs but had an issue at work that prevented me from commenting sooner
developer-guy
force-pushed
the
github-actions
branch
6 times, most recently
from
e11f152 to
0b025a6
Compare
There was a problem hiding this comment.
@alexellis it looks good, do you want to double check before merging
.github/workflows/test.yaml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] |
There was a problem hiding this comment.
it was already like this, I can change it if you want. 👍
.github/workflows/test.yaml
Outdated
| lint: | ||
| strategy: | ||
| matrix: | ||
| go-version: [ 1.14.x ] |
There was a problem hiding this comment.
We use 1.13 everywhere. Any reason for the change?
There was a problem hiding this comment.
In the previous Travis CI setup, go 1.14.x was used, so I didn't change it, I will update with go 1.13, ok.
contrib/get_tools.sh
Outdated
|
|
||
| set -euo pipefail | ||
|
|
||
| KUBE_VERSION=v1.17.0 |
developer-guy
force-pushed
the
github-actions
branch
2 times, most recently
from
d6b4661 to
7b4771b
Compare
Done . |
.github/workflows/test.yaml
Outdated
| push: | ||
| branches: [ "*" ] | ||
| pull_request: | ||
| branches: [ master ] |
There was a problem hiding this comment.
We used * for all branches of pushes and PRs in every other repo, so why are we now putting master on each of these PRs? @LucasRoesler do you know why?
| chmod +x kubectl && \ | ||
| sudo mv kubectl /usr/local/bin/ | ||
|
|
||
| echo ">>> Installing arkade" |
There was a problem hiding this comment.
If we are installing arkade, why not download kubectl with arkade?
arkade get kubectl --version $KUBE_VERSION
mv $HOME/.arkade/bin/kubectl /usr/local/bin/
Signed-off-by: Dentrax <[email protected]> Signed-off-by: Batuhan Apaydın <[email protected]>
developer-guy
force-pushed
the
github-actions
branch
from
7b4771b to
d438fb9
Compare
Signed-off-by: Dentrax [email protected]
Signed-off-by: Batuhan Apaydın [email protected]