github actions workflow enabled #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
There was a problem hiding this comment.
Do you think it makes sense to add a publish workflow and upload multiarch tester commands to the release? it might be overkill thought, @alexellis what do you think?
.github/workflows/build.yaml
Outdated
| version: v1.29 | ||
| args: --issues-exit-code=0 | ||
| - name: test | ||
| run: make build |
There was a problem hiding this comment.
I think this is one improvement we could make here, can we split build into
make test
make tester
so that when it fails, it is more clear in the CI logs about which step failed.
Otherwise 👍
There was a problem hiding this comment.
done, thank you 🙏
alexellis
reviewed
Nov 23, 2020
.github/workflows/build.yaml
Outdated
| push: | ||
| branches: [ "*" ] | ||
| pull_request: | ||
| branches: [ master ] |
There was a problem hiding this comment.
done, thank you 🙏
alexellis
requested changes
Nov 23, 2020
developer-guy
force-pushed
the
master
branch
from
f46619b to
35466a6
Compare
Signed-off-by: Batuhan Apaydın <[email protected]>
developer-guy
force-pushed
the
master
branch
from
35466a6 to
e5c584d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın [email protected]
Description
Github Actions Migration
Motivation and Context
design/approvedlabelHow Has This Been Tested?
Types of changes
Checklist:
git commit -s