Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert-manager helm install instructions #147

Merged

Conversation

LucasRoesler
Copy link
Member

Description

  • Update the k8s cert-manager reference documentation to match the latest release of cert-manager. These docs should now match the latest walkthrough in the cert-manager docs.

Motivation and Context

How Has This Been Tested?

I have not fully tested this yet, but I wanted to get it posted so that others could see it and also help validate it

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

**What**
- Update the k8s cert-manager reference documentation to match the
latest release of cert-manager
- Resolves openfaas#146

Signed-off-by: Lucas Roesler <[email protected]>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexellis alexellis merged commit 3421d17 into openfaas:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cert-manager installation instructions
2 participants