Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Github Actions #1598

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Convert to Github Actions #1598

merged 3 commits into from
Dec 10, 2020

Conversation

Waterdrips
Copy link
Contributor

@Waterdrips Waterdrips commented Nov 23, 2020 •
edited
Loading

Description

This PR converts from travis building to github actions building, testing and publishing the Gateway and BasicAuth containers.

Motivation and Context

How Has This Been Tested?

builds and publishes on my own fork successful, ran a cluster with my ghcr images swapped in and it worked.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Waterdrips Waterdrips mentioned this pull request Nov 23, 2020
Closed
28 tasks
@Waterdrips Waterdrips force-pushed the master branch 3 times, most recently from 67720cb to 3d1e747 Compare November 24, 2020 19:48
Waterdrips
Waterdrips commented Dec 3, 2020
View reviewed changes
gateway/Dockerfile Outdated Show resolved Hide resolved
@Waterdrips Waterdrips changed the title Convert to Github Actions WIP Convert to Github Actions Dec 4, 2020
@alexellis
Copy link
Member

Can I do anything to help with this? We will need it shortly to merge in #1601

@Waterdrips Waterdrips force-pushed the master branch 2 times, most recently from 493bd40 to 068f12a Compare December 5, 2020 20:01
@Waterdrips
Copy link
Contributor Author

ok, tested the last bit now and the gateway funcstore now sets the correct arch (tested on pi3 and pi4.)

@Waterdrips Waterdrips changed the title WIP Convert to Github Actions Convert to Github Actions Dec 5, 2020
@alexellis
Copy link
Member

alexellis commented Dec 7, 2020 •
edited
Loading

How much time does it add to add a faas-cli build of the sample functions folder?

@Waterdrips
Copy link
Contributor Author

How much time does it add to add a faas-cli build of the sample functions folder?

not log, ill add it today. Ill also change the lisence-check to latest while im there

@Waterdrips
Copy link
Contributor Author

How much time does it add to add a faas-cli build of the sample functions folder?

long time, plus sentimentanalysis is broken (wont compile, think its a gcc/musilc issue in alpine)

@alexellis
Copy link
Member

"long time" = 1m 5m 45m?

@alexellis alexellis merged commit ca3d53c into openfaas:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Waterdrips @alexellis