-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add GitHub Actions worflows and remove travis #106
Conversation
2e59b76
to
fd9b623
Compare
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
37b5976
to
2ea2f09
Compare
build ran on my account: https://github.com/cpanato/nats-queue-worker/runs/2289345158?check_suite_focus=true |
/assign @alexellis |
Signed-off-by: Carlos Panato <[email protected]>
Signed-off-by: Carlos Panato <[email protected]>
Hi @cpanato, thank you for this PR. Could you run through a basic test on your repo please? Both for a build, and a release. The release will push a Docker image if it's working right. Given the way the GH actions work, it templates your username and uploads an image to your own custom GHCR.io repo for testing. Alex |
Signed-off-by: Carlos Panato <[email protected]>
@alexellis the two workflows ran on my account build: https://github.com/cpanato/nats-queue-worker/runs/2311878376?check_suite_focus=true image available at PTAL when you have some free time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can also move to |
Description
ci: Add GitHub Actions worflows and remove travis
Motivation and Context
Part of GitHub Actions Migration - tracking issue faas#1585
How Has This Been Tested?
n/a
Types of changes
Checklist:
git commit -s