Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GitHub Actions worflows and remove travis #106

Merged
merged 3 commits into from
Apr 10, 2021

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Apr 7, 2021

Description

ci: Add GitHub Actions worflows and remove travis

Motivation and Context

How Has This Been Tested?

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek derek bot added the new-contributor label Apr 7, 2021
@cpanato cpanato force-pushed the gh-actions branch 2 times, most recently from 2e59b76 to fd9b623 Compare April 7, 2021 16:14
@derek derek bot added the no-dco label Apr 7, 2021
@derek
Copy link

derek bot commented Apr 7, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@cpanato cpanato force-pushed the gh-actions branch 2 times, most recently from 37b5976 to 2ea2f09 Compare April 7, 2021 16:25
@derek derek bot removed the no-dco label Apr 7, 2021
@cpanato
Copy link
Contributor Author

cpanato commented Apr 7, 2021

@cpanato
Copy link
Contributor Author

cpanato commented Apr 7, 2021

/assign @alexellis

cpanato added 2 commits April 7, 2021 18:29
Signed-off-by: Carlos Panato <[email protected]>
Signed-off-by: Carlos Panato <[email protected]>
@alexellis
Copy link
Member

alexellis commented Apr 9, 2021

Hi @cpanato, thank you for this PR.

Could you run through a basic test on your repo please? Both for a build, and a release. The release will push a Docker image if it's working right.

Given the way the GH actions work, it templates your username and uploads an image to your own custom GHCR.io repo for testing.

Alex

Signed-off-by: Carlos Panato <[email protected]>
@cpanato
Copy link
Contributor Author

cpanato commented Apr 10, 2021

@alexellis the two workflows ran on my account

build: https://github.com/cpanato/nats-queue-worker/runs/2311878376?check_suite_focus=true
publish: https://github.com/cpanato/nats-queue-worker/runs/2311894847?check_suite_focus=true

image available at ghcr.io/cpanato/nats-queue-worker:v99.99.99

PTAL when you have some free time

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 6e14420 into openfaas:master Apr 10, 2021
@alexellis
Copy link
Member

We can also move to secrets.GITHUB_TOKEN now instead of individual secrets that I create and manage.

@cpanato cpanato deleted the gh-actions branch April 11, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants