Don't from value_command when value_from file is present

If a value_command is set and a value_from file is already on
the disk, then do not regenerate the file.

Fixes: #198

Tested e2e with k3d, and checked that the local file in /tmp/
was not re-created with a new value, when oauth was enabled.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

pkg/types/secrets.go

@@ -34,19 +34,24 @@ func BuildSecretTask(kvn KeyValueNamespaceTuple) execute.ExecTask {
 	}
 
 	for _, file := range kvn.Files {
+		filePath := file.ExpandValueFrom()
 		if len(file.ValueCommand) > 0 {
+			if _, err := os.Stat(filePath); err != nil {
 
-			valueTask := execute.ExecTask{
-				Command:     file.ValueCommand,
-				StreamStdio: true,
-			}
-			res, err := valueTask.Execute()
-			if err != nil {
-				log.Fatal(fmt.Errorf("error executing value_command: %s", file.ValueCommand))
-			}
+				valueTask := execute.ExecTask{
+					Command:     file.ValueCommand,
+					StreamStdio: true,
+				}
+				res, err := valueTask.Execute()
+				if err != nil {
+					log.Fatal(fmt.Errorf("error executing value_command: %s", file.ValueCommand))
+				}
 
-			if res.ExitCode != 0 {
-				log.Fatal(fmt.Errorf("error running value_command: %s, stderr: %s", file.ValueCommand, res.Stderr))
+				if res.ExitCode != 0 {
+					log.Fatal(fmt.Errorf("error running value_command: %s, stderr: %s", file.ValueCommand, res.Stderr))
+				}
+			} else {
+				fmt.Printf("%s exists, not running value_command\n", filePath)
 			}
 		}