Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Commit

Permalink
Add cookie_root_domain to system dashboard
Browse files Browse the repository at this point in the history
The env var for cookie_root_domain was missing from the system_dashboard
deployment, this meant when users with OAuth enabled did not get their
token removed when clicking logout.

see openfaas/openfaas-cloud#623
see openfaas/openfaas-cloud#624

This was tested by updating an existing deployment with the new setting
and logging out, the cookie was removed and the oauth flow was triggered
to gain a new token

Signed-off-by: Alistair Hey <[email protected]>
  • Loading branch information
Waterdrips authored and alexellis committed May 11, 2020
1 parent 58e4e87 commit 97da21b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions templates/dashboard_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ environment:
pretty_url: {{.Scheme}}://user.{{.RootDomain}}/function
# Comment out if not using public pretty-URL
query_pretty_url: 'true'
# Cookie root domain is needed to remove OAuth tokens when using OAuth, it doesnt matter if its set when not using OAuth
cookie_root_domain: '.system.{{.RootDomain}}'

0 comments on commit 97da21b

Please sign in to comment.