Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Commit

Permalink
Update docs to clarify registry-login command
Browse files Browse the repository at this point in the history
The registry-login usage command was copied from faas-cli and doent look
like it was changed, the password-stdin flag was referencing the gateway
password.

This also changes the docs to specify pressing ctrl+d when trying a
password to close the input.

Signed-off-by: Alistair Hey <[email protected]>
  • Loading branch information
Waterdrips authored and alexellis committed Sep 16, 2020
1 parent ac46a1c commit be63099
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion USER_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ If you are using Dockerhub you only need to supply your `--username` and `--pass
```sh

ofc-bootstrap registry-login --username <your-registry-username> --password-stdin
(the enter your password and hit return)
(then enter your password and use ctrl+d to finish input)
```

You could also have you password in a file, or environment variable and echo/cat this instead of entering interactively
Expand Down
2 changes: 1 addition & 1 deletion cmd/registry_login.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func init() {
registryLoginCommand.Flags().String("server", "https://index.docker.io/v1/", "The server URL, it is defaulted to the docker registry")
registryLoginCommand.Flags().String("username", "", "The Registry Username")
registryLoginCommand.Flags().String("password", "", "The registry password")
registryLoginCommand.Flags().BoolP("password-stdin", "s", false, "Reads the gateway password from stdin")
registryLoginCommand.Flags().BoolP("password-stdin", "s", false, "Reads the docker password from stdin, either pipe to the command or remember to press ctrl+d when reading interactively")

registryLoginCommand.Flags().Bool("ecr", false, "If we are using ECR we need a different set of flags, so if this is set, we need to set --username and --password")
registryLoginCommand.Flags().String("account-id", "", "Your AWS Account id")
Expand Down

0 comments on commit be63099

Please sign in to comment.