Stop streaming secret creation

This lead to a double print, the patch prints only once.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

cmd/apply.go

@@ -668,14 +668,17 @@ func createSecrets(plan types.Plan) error {
 			fmt.Printf("Creating secret: %s\n", secret.Name)
 
 			command := types.BuildSecretTask(secret)
-			fmt.Printf("Secret - %s %s\n", command.Command, command.Args)
+			fmt.Printf("Secret - %s %s\n", command.Command, strings.Join(command.Args, " "))
 			res, err := command.Execute()
-
 			if err != nil {
 				log.Println(err)
 			}
 
-			fmt.Println(res)
+			out := res.Stdout
+			if len(res.Stderr) > 0 {
+				out = out + " / " + res.Stderr
+			}
+			fmt.Printf("%s\n", out)
 		}
 	}
 

pkg/types/secrets.go

@@ -13,7 +13,7 @@ func BuildSecretTask(kvn KeyValueNamespaceTuple) execute.ExecTask {
 	task := execute.ExecTask{
 		Command:     "kubectl",
 		Args:        []string{"create", "secret", "generic", "-n=" + kvn.Namespace, kvn.Name},
-		StreamStdio: true,
+		StreamStdio: false,
 	}
 
 	if len(kvn.Type) > 0 {
@@ -40,7 +40,7 @@ func BuildSecretTask(kvn KeyValueNamespaceTuple) execute.ExecTask {
 
 				valueTask := execute.ExecTask{
 					Command:     file.ValueCommand,
-					StreamStdio: true,
+					StreamStdio: false,
 				}
 				res, err := valueTask.Execute()
 				if err != nil {