This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Update the OpenFaaS installation to only pull images if not present #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/openfaas/faas-netes/tree/master/chart/openfaas Did we get the right setting? This is to prevent images from being pulled for functions if already present. |
|
I think this should be:
|
Waterdrips
force-pushed
the
image-pull-policy-change
branch
from
c8bdeba to
7293dd0
Compare
The bootstrap script installed OpenFaaS in a way that the images were always pulled even if they existed on the node. This has been changed to pull if they are not present to reduce cold-start times when the functions are scaled down and up. Signed-off-by: Alistair Hey <[email protected]>
Waterdrips
force-pushed
the
image-pull-policy-change
branch
from
7293dd0 to
3e81c56
Compare
|
Good spot @alexellis - sorry! I have updated the correct image_pull_policy now - Shown after an install below:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bootstrap script installed OpenFaaS in a way that the images were
always pulled even if they existed on the node. This has been changed
to pull if they are not present to reduce cold-start times when the
functions are scaled down and up.
Signed-off-by: Alistair Hey [email protected]
Closes #100
@alexellis is this all that is required for #100 ? seems like a small pr
How Has This Been Tested?
Installing OFC onto a new cluster with the new config and testing by calling the functions.
It all worked
Checklist:
I have:
git commit -s