This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Rename system-metrics to metrics for 0.12.0 of OFC #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Relates to issue openfaas/openfaas-cloud#573 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
|
Could you verify before we merge? |
This seemed to cause a timing issue during bootstrap with K8s 1.16 and GitLab. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
|
With GitLab, TLS and K8s 1.16 in k3d I'm seeing: |
GitHub, K3s (Civo Kubernetes) (v1.16 k8s) Ill try a GitLab install now |
|
It could be a timing issue. We might need to halt if OpenFaaS didn't come up as expected. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]
Description
Rename system-metrics to metrics for 0.12.0 of OFC
cc @Waterdrips