This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Add a password STDIN option to registry login #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waterdrips
force-pushed
the
password-stdin
branch
2 times, most recently
from
71e2274 to
5816e7d
Compare
|
Did CI fail? |
I had not added the --password-stdin option to registry-login command, it has now been added so users dont leave stuff in history Signed-off-by: Alistair Hey <[email protected]>
Waterdrips
force-pushed
the
password-stdin
branch
from
5816e7d to
f78dfae
Compare
go fmt again. Still need to setup my commit hooks on this laptop :/ |
|
Thank you. 0.8.8 contains this fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had not added the --password-stdin option to
registry-login command, it has now been added so
users dont leave stuff in history
closes #169
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
go build && echo $PASSWORD | ./ofc-bootstrap registry-login --username foo --password-stdincreates the same file as
go build && ./ofc-bootstrap registry-login --username foo --password $PASSWORD(tested by creating both and using
diffto check they are identicalChecklist:
I have:
git commit -s