This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Enable a private CUSTOMERS file in a secret #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issues with merging lists of secrets where the mergo library was overwriting values instead of doing a union. Ref: darccio/mergo#107 Enables a private customer list via a secret instead of a public HTTPS URL. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
This patch adds a custom piece of unit-tested code to merge the list of secrets using a union since the mergo library doesn't appear to be able to do that at present. Ref: darccio/mergo#107 A separate named secret is used for openfaas/fn namespaces so that a union merge can be performed using the name as a key. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
customers_secret when enabled uses a Kubernetes secret instead of a URL Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable a private CUSTOMERS file in a secret
Ref: openfaas/openfaas-cloud#591
Enable private customers list and merging of secrets
This patch adds a custom piece of unit-tested code to merge the
list of secrets using a union since the mergo library doesn't
appear to be able to do that at present.
Ref: darccio/mergo#107
A separate named secret is used for openfaas/fn namespaces so
that a union merge can be performed using the name as a key.
Fixes an issues with merging lists of secrets where the mergo
library was overwriting values instead of doing a union.
Enables a private customer list via a secret instead of a public
HTTPS URL.
How Has This Been Tested?
Testing e2e with DOKS, worked as expected with the customers secret file.
@Waterdrips verified before/after editing the secret to add a new user.