This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Update to 0.13.6 openfaas-cloud #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alistair Hey <[email protected]>
The secret type was set to `literals` not files, this means when you copy the file and set the value_from to a filepath, it actually uses the "value_from" as the literal value and not the contents of the file. I have also added a clarifying comment for usage Signed-off-by: Alistair Hey <[email protected]>
Signed-off-by: Alistair Hey <[email protected]>
Waterdrips
force-pushed
the
0-13-5-uupgrade
branch
from
638198d to
300e506
Compare
Waterdrips
changed the title
alexellis
reviewed
Mar 3, 2020
| - name: "of-customers" | ||
| literals: |
There was a problem hiding this comment.
I think so, if the intention was to read it from a file rather than a literal?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alistair Hey [email protected]
Description
Update OFC version to 0.13.5
How Has This Been Tested?
This has been tested with:
0.13.1 cluster upgraded to 0.13.5 and then 0.13.6
and 0.13.5 upgraded to 0.13.6.
Clusters up and running!
Checklist:
I have:
git commit -s