This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Move github app HTML templates to templates folder #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The html templates for the github app creation helper have been moved into `./templates/github/` so a user can avoid copying extra files/folders if using ofc-bootstrap outside the clone dir. This was tested by building and running the create-github-app command and generating a github app Signed-off-by: Alistair Hey <[email protected]>
|
I feel like this is a core part of the package, but I see the point so will merge it for usability in pipelines. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The html templates for the github app creation helper have been moved
into
./templates/github/so a user can avoid copying extrafiles/folders if using ofc-bootstrap outside the clone dir.
Fixes #202
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
This was tested by building and running the create-github-app command
and generating a github app
Checklist:
I have:
git commit -s