Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Convert to using GHCR images #236

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

Waterdrips
Copy link
Contributor

@Waterdrips Waterdrips commented Dec 3, 2020

Signed-off-by: Alistair Hey [email protected]

Description

This moved over to using the GHCR images at the most recent version,
0.14.4

How Has This Been Tested?

Tested by deploying to a new cluster, all images pulled and started
cluster then live

Checklist:

I have:

  • checked my changes follow the style of the existing code / OpenFaaS repos
  • updated the documentation and/or roadmap in README.md
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

This moved over to using the GHCR images at the most recent version,
0.14.4

Tested by deploying to a new cluster, all images pulled and started
Signed-off-by: Alistair Hey <[email protected]>
cd ./dashboard
faas-cli template pull
faas-cli deploy
TAG=0.14.4 faas-cli deploy -f ./dashboard/stack.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can that tag be read from init.yaml and passed down?

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit c7114a5 into openfaas:master Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants