This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Update dashboard config fields #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Wilson <[email protected]>
4 tasks
Signed-off-by: Brandon Wilson <[email protected]>
Waterdrips
approved these changes
Dec 14, 2020
| @@ -239,6 +239,7 @@ scm: github | |||
| ## Populate from GitHub App | |||
| github: | |||
| app_id: "24304" | |||
| public_link: "https://github.com/apps/o6s-io" | |||
There was a problem hiding this comment.
We need a docs update to ask a user to configure this when configuring the app
There was a problem hiding this comment.
What happens if it's left blank?
There was a problem hiding this comment.
The dashboard icon wouldn't be displayed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon Wilson [email protected]
Description
Supports additional ofc dashboard configuration fields added in openfaas/openfaas-cloud#706
How Has This Been Tested?
Followed ofc-bootstrap user guide using these changes along with this patch to install ofc on k3s.
Ran each of the following once with
scmasgithuband again asgitlab:The deployed dashboard includes the correct icons and links based on the configuration
Checklist:
I have:
git commit -s