This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Fix list-functions deployment in stack.yml #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move to GHCR had a rogue vim replace all (functions --> ghcr.io/) and thus the list-functions function got some random replacments. This has been tested on a new cluster and the broken credentials for list-function have been restored and now it can call the gateway Signed-off-by: Alistair Hey <[email protected]>
Waterdrips
force-pushed
the
Waterdrips-fix-dashboard
branch
from
ce36be3 to
b32da75
Compare
|
How can we start picking this kind of error up in CI? |
|
We would need to start running deplyoemts/functions/reading the ui/checking the logs etc |
|
Can you raise an issue and propose how you would have detected this error that the PR fixes? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #242
The move to GHCR had a rogue vim replace all (functions --> ghcr.io/)
and thus the list-functions function got some random replacments.
This has been tested on a new cluster and the broken credentials for
list-function have been restored and now it can call the gateway
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
New cluster deployment from scratch on master, then change the fix and re-deploy and it works
Checklist:
I have:
git commit -s