This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Github Actions migration #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds github actions support and create a multiarch build for edge-auth. This build was tested on my own OFC installation by building, pusing to my GH repo and deploying the built image Signed-off-by: Alistair Hey <[email protected]>
This commit converts the edge-route dockerfile to multi-arch builds. This was tested on a ofc cluster. After swapping in the new container the service worked as normal Signed-off-by: Alistair Hey <[email protected]>
|
openfaas/faas#1585 part of this |
This builds the faas-cli components with github actions as part of CI Signed-off-by: Alistair Hey <[email protected]>
alexellis
reviewed
Nov 18, 2020
| - name: Run CI | ||
| run: sh ./contrib/ci.sh | ||
|
|
||
| # Test building the non-cli Containers |
alexellis
reviewed
Nov 18, 2020
| - name: Login to Docker Registry | ||
| uses: docker/login-action@v1 | ||
| with: | ||
| username: ${{ github.repository_owner }} |
There was a problem hiding this comment.
Wait, who is the owner when it's an org? Can you test and find out please?
There was a problem hiding this comment.
If you use DOCKER_USERNAME it will just be easier
There was a problem hiding this comment.
secrets.DOCKER_USERNAME will cause every occurrence of the username to be starred out, which is annoying.
There was a problem hiding this comment.
We have that everywhere else and I don't think that openfaas can push images? I can't get a PTA for openfaas the owner.
|
This looks great - we are getting there! I'm not seeing the gitlab stack file being built? How about the aws one too? |
|
I'll put a PR up for this for you to review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Big PR to move over to GH Actions for building and publishing OFC containers
This will build containers and stack.yml and publish new versions with a tag that matches a release tag.
We will need to switch the chart to be using the release tag and pull from ghcr.io rather than dockerhub next.
Closes #684
How Has This Been Tested?
Containers are built and publised on relese tag
They are built and the chart tests are run on commits and PRs
How are existing users impacted? What migration steps/scripts do we need?
We will be moving to GHCR for hosting images so will need to update the chart once they are pushed and public.
We will then need to update the chart to use the release tag as the image versions as we are going to be pushing those image tags from now on, rather than keeping each container on its own version.
This should make maintaining the chart and stack.yml easier going forward. It will however mean that users should be updating all of ofc components on each release rather than just the components that change. This should be easier once the helm chart goes into ofc-bootstrap as theres a flag being added to run only the chart install
Checklist:
I have:
git commit -s