Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #36

Closed
wants to merge 1 commit into from
Closed

Update README.md #36

wants to merge 1 commit into from

Conversation

ikotler
Copy link

@ikotler ikotler commented Jun 10, 2020

in Python it's str(), not string()

in Python it's str(), not string()
@derek
Copy link

derek bot commented Jun 10, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Jun 10, 2020
@alexellis
Copy link
Member

That was a typo. I am aware as a regular python user 😅

Can you sign off your PR?

@alexellis alexellis closed this in 90bcd72 Jun 10, 2020
@ikotler ikotler deleted the patch-1 branch June 14, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants