Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for exception thrown when RAW_BODY is undefined #38

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

dsbibby
Copy link
Contributor

@dsbibby dsbibby commented Jul 7, 2020

Signed-off-by: David Bibby [email protected]

Description

Specifies a default value for the RAW_BODY environment variable

Motivation and Context

Fixes #37

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Before this change my function required the RAW_BODY environment variable to be defined otherwise an exception was thrown.
After making this change the RAW_BODY environment variable no longer has to be defined and assumes the value "false" if it is not specified.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexellis
Copy link
Member

Hi, thanks for the PR

Alex

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 0ca73dc into openfaas:master Jul 7, 2020
@alexellis
Copy link
Member

If you'd like to join us on Slack, please feel free to join to chat with the community. https://slack.openfaas.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index.py throws exception if RAW_DATA not defined
2 participants