Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylesheets (Baseline) reshuffling (Phase 1): Separate structural rules from stylistic rules #17

Closed
smillart opened this issue Jul 14, 2020 · 0 comments · Fixed by #115
Closed

Stylesheets (Baseline) reshuffling (Phase 1): Separate structural rules from stylistic rules #17

smillart opened this issue Jul 14, 2020 · 0 comments · Fixed by #115
Assignees
@smillart
Labels
enhancement New feature or request
Milestone
Kiso (基礎) 3.1.0 (...

Comments

@smillart
Copy link
Collaborator

smillart commented Jul 14, 2020 •
edited
Loading

Following various projects, we realized that most of the front-end developers did not take advantage of using the stylesheets (Baseline) defined by the Drupal Kiso (基礎) base theme for most HTML elements and the Drupal components. CSS assets or even entire libraries the sub-theme inherits from the Drupal Kiso (基礎) base theme are replaced or removed to define own default styles.

This reshuffling (Phase 1) will ensure to separate structural rules from stylistic rules, that will allow to rulesets to be grouped efficiently enforcing the separation of concerns. Therefore, that can be easily overridden by front-end developers from the THEMENAME.info.yml file.
@smillart smillart changed the title Reshuffling stylesheets (Baseline) by separating structural rules from stylistic rules Reshuffle stylesheets (Baseline) by separating structural rules from stylistic rules Jul 14, 2020
@smillart smillart self-assigned this Jul 14, 2020
@smillart smillart added this to the Kiso (基礎) 3.0 milestone Jul 14, 2020
@smillart smillart changed the title Reshuffle stylesheets (Baseline) by separating structural rules from stylistic rules Stylesheets (Baseline) reshuffling (Phase 1): Separate structural rules from stylistic rules Jan 12, 2024
@smillart smillart added the enhancement New feature or request label Jan 12, 2024
smillart pushed a commit that referenced this issue Jan 16, 2024
Issue #17: Moved libraries loading from preprocess function to page a…
2b9c3b0 
…ttachments alter hook
@smillart smillart linked a pull request Jan 16, 2024 that will close this issue
Feature/#17: (Phase 1) Separated structural rules from stylistic rules for the stylesheets (Baseline) #115
Merged
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Removed/Updated config files (STARTERKIT included) since S…
ed77c96 
…ass Framework update
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated config (variables overrides) since Sass Framework …
a1fc307 
…update
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Upadated "visual-styling" assets library with stylistic ru…
dc9c020 
…les only
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated (s)css structural and stylistic rules for the `r…
1c87948 
…eboot` assets library
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated (s)css structural and stylistic rules for the `e…
772ff4a 
…lements` assets library
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated (s)css structural and stylistic rules for the `l…
17d92b0 
…ayout` assets library
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated (s)css structural and stylistic rules for the `b…
f23e6cc 
…locks` assets library
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated (s)css structural and stylistic rules for the `n…
dce04ff 
…avigations` assets library
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the fields assets library structural and stylist…
61c8762 
…ic `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the file assets library structural and stylistic…
ffba243 
… `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the nodes assets library structural and stylisti…
10fb8e1 
…c `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the miscs assets library structural and stylisti…
5c34e97 
…c `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the messages assets library structural and styli…
9156757 
…stic `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the links--language-block assets library structu…
64f92e5 
…ral and stylistic `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the back-to-top assets library structural and st…
2170b9a 
…ylistic `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the tooltip assets library structural and stylis…
c1ab026 
…tic `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the outdated-browser assets library structural a…
455dc55 
…nd stylistic `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the track-focus assets library structural and st…
7ed2663 
…ylistic `(s)css` rules
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the "External Links" library override (s)css sty…
361d9b7 
…les since Sass Framework update
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated the "Federal Header" library override (s)css sty…
7171329 
…les since Sass Framework update
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated following libraries overrides (s)css styles sinc…
f0b549d 
…e Sass Framework update

- Alignment classes
- Float clearing
- Invisible content & Screenreaders
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Removed no more used partial scss files from the `visual…
6d49f8c 
…-styling` assets library
smillart pushed a commit that referenced this issue Jan 18, 2024
Merge branch '3.1.x' into feature/#17
9899b14 
# Conflicts:
#	css/theme/theme--kiso.css
#	kiso.libraries.yml
#	scss/config/_variable-overrides.scss
#	scss/theme/elements/_headings.scss
smillart pushed a commit that referenced this issue Jan 18, 2024
Issue #17: Updated STARTERKIT documentation
b49e23f
smillart added a commit that referenced this issue Jan 23, 2024
@smillart
Merge pull request #115 from feature/#17: (Phase 1) Separated structu…
fd09309 
…ral rules from stylistic rules for the stylesheets (Baseline)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smillart smillart

Labels
enhancement New feature or request
Projects
None yet
Milestone
Kiso (基礎) 3.1.0 (Beta1)
1 participant
@smillart