-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/#64: Empty regions verification optimization #124
Conversation
…b module "Twig Real Content"" This reverts commit c1697b8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment added regarding the kiso_preprocess_html()
function that contains a potentially unused $variables['page_tools']
variable. @GyD Could you please take a look? Thanks!
This pull request relates to BOSA_0100-358 (JIRA issue) and contains Yves's (@GyD) attempt to improve the performance of Kiso.
has_{region}
functionality is kept so theme using it still can use it. Functions used to check if region is empty are kept but adapted so theme using it still can use it.page_{region}
is introduced for future themes, that variable store the rendered output of thepage.region
so it can be called in theme without re-redering the region again,_kiso_render_region()
is introduced to avoid calling\Drupal::service('renderer')->render($region);
each time but also not mark the region as rendered since the region is not passed by reference. This way if you need to alter region content afterkiso_preprocess_html()
andkiso_preprocess_page()
it still behave as Drupal core.