Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intt optimization #876

Merged
merged 4 commits into from
Oct 23, 2024
Merged

intt optimization #876

merged 4 commits into from
Oct 23, 2024

Conversation

pascoec
Copy link
Collaborator

@pascoec pascoec commented Oct 8, 2024

5% - 9% improvement for clang. No Change for gcc.

@pascoec pascoec added the optimization Improves performance label Oct 8, 2024
@pascoec pascoec added this to the Release 1.2.2 milestone Oct 8, 2024
@pascoec pascoec self-assigned this Oct 8, 2024
@pascoec pascoec linked an issue Oct 8, 2024 that may be closed by this pull request
Optimize INTT #872
Closed
caesaretos
caesaretos previously requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@caesaretos caesaretos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more comments to explain the implementation of the optimization. It is hard to understand the code this way.

@yspolyakov
Copy link
Contributor

yspolyakov commented Oct 18, 2024 •
edited
Loading

I am concerned about the readability of the NTT code. It is becoming hard to understand. We should probably add a lot of comments to explain every step.

@caesaretos
Copy link
Collaborator

Looks good to me now.

@pascoec pascoec requested review from caesaretos and removed request for caesaretos October 23, 2024 20:17
@dsuponitskiy dsuponitskiy merged commit 8f72e90 into dev Oct 23, 2024
@pascoec pascoec deleted the issue-872 branch October 24, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yspolyakov yspolyakov yspolyakov approved these changes

@caesaretos caesaretos caesaretos left review comments

Assignees

@pascoec pascoec

Labels
optimization Improves performance
Projects
None yet
Milestone
Release 1.2.2
Development

Successfully merging this pull request may close these issues.

Optimize INTT
4 participants
@pascoec @yspolyakov @caesaretos @dsuponitskiy