Match pathname before :name in routes #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By matching pathname before :name in routes, we're sure it is exluded from the :name match, hence not triggering the ParameterOrVariable component rendering. This is what was causing the loading div to be rendered in home page, having as a side effect the style bug.
sandcha
force-pushed
the
fix-loading-in-landing
branch
from
57a8ae2 to
fbe3906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199
By matching pathname before :name in routes, we're sure it is exluded
from the :name match, hence not triggering the ParameterOrVariable
component rendering.
This is what was causing the loading div to be rendered in home page,
having as a side effect the style bug.
To test, follow #199 example.