Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend set input #1174

Merged
merged 25 commits into from
Jun 27, 2023
Merged

Extend set input #1174

merged 25 commits into from
Jun 27, 2023

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Dec 16, 2022 •
edited
Loading

New Features

  • Allows for dispatching and dividing inputs over a broader range.
    • For example, divide a monthly variable by week.

@coveralls
Copy link

coveralls commented Dec 16, 2022 •
edited
Loading

Coverage Status

coverage: 73.99% (-3.8%) from 77.804% when pulling 607f9e8 on better-set-input into 7bd277a on master.

@benjello benjello self-requested a review December 16, 2022 23:26
@bonjourmauko bonjourmauko force-pushed the add-weeks branch 2 times, most recently from 4a8cf06 to a24de40 Compare December 19, 2022 21:03
bonjourmauko and others added 22 commits June 26, 2023 13:51
@bonjourmauko
Add periods to doctests path
4a2d5d1
@bonjourmauko
Add periods to tests path
63931f5
@bonjourmauko
Ignore mypy periods' tests errors
384cb8e
@bonjourmauko
Fix instants' docstrings
1226334
@bonjourmauko
Fix periods' doctests
7112262
@bonjourmauko
Fix periods' helpers doctests
e8e647b
@bonjourmauko
Add tests to periods.instant
9fd327c
@bonjourmauko
Add tests to periods.instant_date
9caa64a
@bonjourmauko
Add tests to periods.key_period_size
42f52b8
@bonjourmauko
Add doctest to periods.unit_weights
2ab5548
@bonjourmauko
Add doctest to periods.unit_weight
db4e06a
@bonjourmauko
Fix typo in doc
56ad038
@bonjourmauko
Extract raise error from period builder
8bd4ecf
@bonjourmauko
Refactor period's str year tests
f2ff5b3
@bonjourmauko
Refactor period's str month tests
213e98a
@bonjourmauko
Refactor period's str day tests
2694717
@bonjourmauko
Consolidate tests
de8a3ac
@bonjourmauko
Add date units to periods
699aff2
@bonjourmauko
Add week to variables
3cf30f4
@bonjourmauko
Fix week/day offset
3886f35
@bonjourmauko
Fix eternity edge case
b724bce
@bonjourmauko
Skip tests with deprecated syntax
332d5d7
@bonjourmauko bonjourmauko changed the title Improve set input Extend set input Jun 26, 2023
@bonjourmauko bonjourmauko added scope:developer-experience level:intermediate Requires average OpenFisca experience kind:feat A feature request, a feature deprecation labels Jun 26, 2023
@bonjourmauko bonjourmauko changed the base branch from add-weeks to master June 26, 2023 18:32
@bonjourmauko bonjourmauko merged commit 94f68f4 into master Jun 27, 2023
@bonjourmauko bonjourmauko deleted the better-set-input branch June 27, 2023 00:13
@bonjourmauko bonjourmauko added this to the Add support for weeks milestone Sep 17, 2024
@bonjourmauko bonjourmauko mentioned this pull request Sep 17, 2024
Draft
@bonjourmauko bonjourmauko mentioned this pull request Sep 25, 2024
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello benjello approved these changes

@verbman verbman Awaiting requested review from verbman

@Br3nda Br3nda Awaiting requested review from Br3nda

Assignees
No one assigned
Labels
kind:feat A feature request, a feature deprecation level:intermediate Requires average OpenFisca experience scope:developer-experience
Projects
None yet
Milestone
Add support for weeks
Development

Successfully merging this pull request may close these issues.
3 participants
@bonjourmauko @coveralls @benjello