Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove coveralls #1283

Merged
merged 8 commits into from
Oct 18, 2024
Merged

build: remove coveralls #1283

merged 8 commits into from
Oct 18, 2024

Conversation

benjello
Copy link
Member

@benjello benjello commented Oct 18, 2024 •
edited by bonjourmauko
Loading

Technical changes

  • Remove covearalls

Fixes #1073

@benjello
Copy link
Member Author

@bonjourmauko : got a doctest failure

@bonjourmauko bonjourmauko self-requested a review October 18, 2024 15:52
@bonjourmauko bonjourmauko added the kind:build Pull requests that update a dependency file label Oct 18, 2024
@bonjourmauko
Copy link
Member

@bonjourmauko : got a doctest failure

Weird that it didn't fail before. These are expected, however very useless, errors.

@bonjourmauko
Copy link
Member

@bonjourmauko : got a doctest failure

Weird that it didn't fail before. These are expected, however very useless, errors.

Actually not that useless.

For example, if you want to build a recarray containing str, you can define by hand the itemsize. Thanks to the testing matrix, we will now that in windows we can have an offset error of 10 bits, and that we should better pad automatically and increase the offset. These are very weird situations, so it is actually good to be able to catch them.

@bonjourmauko bonjourmauko force-pushed the remove-coverall branch 2 times, most recently from 86c8c7b to de26d39 Compare October 18, 2024 16:32
@bonjourmauko bonjourmauko changed the title Remove coverall build: remove coveralls Oct 18, 2024
@bonjourmauko
Copy link
Member

@benjello it is your PR so I leave the merge to you.

@benjello benjello merged commit 2bd629b into master Oct 18, 2024
46 of 57 checks passed
@benjello benjello deleted the remove-coverall branch October 18, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonjourmauko bonjourmauko bonjourmauko approved these changes

Assignees

@benjello benjello

Labels
kind:build Pull requests that update a dependency file
Projects
OpenFisca International
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused Coveralls
2 participants
@benjello @bonjourmauko