fix: fix facets association bug

frontend/src/mixins/history.ts

@@ -5,6 +5,7 @@ import {
   removeParenthesis,
 } from '../utils/url';
 import {isNullOrUndefined} from '../utils';
+import {DEFAULT_SEARCH_NAME} from '../utils/constants';
 import {BuildParamsOutput} from './search-ctl';
 import {property} from 'lit/decorators.js';
 import {QueryOperator} from '../utils/enums';
@@ -117,7 +118,7 @@ export const SearchaliciousHistoryMixin = <T extends Constructor<LitElement>>(
     @property({attribute: false})
     query = '';
     @property()
-    name = 'searchalicious';
+    name = DEFAULT_SEARCH_NAME;
 
     // stub methods defined in search-ctl
     _sortElement = (): SearchaliciousSort | null => {

frontend/src/mixins/search-action.ts

@@ -1,6 +1,7 @@
 import {LitElement} from 'lit';
 import {Constructor} from './utils';
 import {BaseSearchDetail, LaunchSearchEvent} from '../events';
+import {DEFAULT_SEARCH_NAME} from '../utils/constants';
 import {SearchaliciousEvents} from '../utils/enums';
 import {property} from 'lit/decorators.js';
 
@@ -21,7 +22,7 @@ export const SearchActionMixin = <T extends Constructor<LitElement>>(
 ): Constructor<SearchActionMixinInterface> & T => {
   class SearchActionMixinClass extends superClass {
     @property({attribute: 'search-name'})
-    searchName = 'searchalicious';
+    searchName = DEFAULT_SEARCH_NAME;
 
     /**
      * Launches a search event.

frontend/src/mixins/search-ctl.ts

@@ -15,7 +15,7 @@ import {Constructor} from './utils';
 import {SearchaliciousSort} from '../search-sort';
 import {SearchaliciousFacets} from '../search-facets';
 import {setCurrentURLHistory} from '../utils/url';
-import {FACETS_DIVIDER} from '../utils/constants';
+import {DEFAULT_SEARCH_NAME, FACETS_DIVIDER} from '../utils/constants';
 import {
   HistorySearchParams,
   SearchaliciousHistoryInterface,
@@ -67,7 +67,7 @@ export const SearchaliciousSearchMixin = <T extends Constructor<LitElement>>(
      * The name of this search
      */
     @property()
-    override name = 'searchalicious';
+    override name = DEFAULT_SEARCH_NAME;
 
     /**
      * The base api url
@@ -119,9 +119,16 @@ export const SearchaliciousSearchMixin = <T extends Constructor<LitElement>>(
 
     /** list of facets containers */
     _facetsParentNode() {
-      return document.querySelectorAll(
-        `searchalicious-facets[search-name=${this.name}]`
-      );
+      if (this.name === DEFAULT_SEARCH_NAME) {
+        // manually filtering, as it may be implicit
+        return Array.from(
+          document.querySelectorAll('searchalicious-facets')
+        ).filter((facets) => facets.searchName === this.name);
+      } else {
+        return document.querySelectorAll(
+          `searchalicious-facets[search-name=${this.name}]`
+        );
+      }
     }
 
     /**

frontend/src/mixins/search-results-ctl.ts

@@ -5,6 +5,7 @@ import {
   EventRegistrationInterface,
   EventRegistrationMixin,
 } from '../event-listener-setup';
+import {DEFAULT_SEARCH_NAME} from '../utils/constants';
 import {SearchaliciousEvents} from '../utils/enums';
 import {SearchResultEvent} from '../events';
 import {Constructor} from './utils';
@@ -38,7 +39,7 @@ export const SearchaliciousResultCtlMixin = <T extends Constructor<LitElement>>(
      * this corresponds to `name` attribute of corresponding search-bar
      */
     @property({attribute: 'search-name'})
-    searchName = 'searchalicious';
+    searchName = DEFAULT_SEARCH_NAME;
 
     /**
      * this will be true if we already launched a search

frontend/src/test/search-pages_test.ts

@@ -1,4 +1,5 @@
 import {SearchaliciousPages} from '../search-pages';
+import {DEFAULT_SEARCH_NAME} from '../utils/constants';
 import {SearchaliciousEvents} from '../utils/enums';
 import {SearchResultDetail, SearchResultEvent} from '../events';
 
@@ -13,7 +14,7 @@ suite('searchalicious-pages', () => {
     pageCount: number
   ) => {
     const detail: SearchResultDetail = {
-      searchName: 'searchalicious',
+      searchName: DEFAULT_SEARCH_NAME,
       results: [], // we don't really care
       count: Math.ceil(pageCount / 10),
       pageCount: pageCount,

frontend/src/test/search-results_test.ts

@@ -1,4 +1,5 @@
 import {SearchaliciousResults} from '../search-results';
+import {DEFAULT_SEARCH_NAME} from '../utils/constants';
 import {SearchaliciousEvents} from '../utils/enums';
 import {SearchResultDetail} from '../events';
 
@@ -16,7 +17,7 @@ suite('searchalicious-results', () => {
     results: Array<Record<string, unknown>>
   ) => {
     const detail: SearchResultDetail = {
-      searchName: 'searchalicious',
+      searchName: DEFAULT_SEARCH_NAME,
       results: results,
       count: 3,
       pageCount: 1,

frontend/src/utils/constants.ts

@@ -1,3 +1,5 @@
 export const FACET_TERM_OTHER = '--other--';
 
 export const FACETS_DIVIDER = ',';
+
+export const DEFAULT_SEARCH_NAME = 'searchalicious';