feat: be able to create scatter plots #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only in frontend right now
… vega-scatter-plot
… vega-scatter-plot
… vega-scatter-plot
alexgarel
requested changes
Jun 28, 2024
There was a problem hiding this comment.
@Marc-AntoineA I made some comments.
Also an important thing to change: add comments, at least to every class and to big blocks of codes. At least a summary of what you are doing. (and for classes the big picture).
* remove mixin * put primary color in config * more comments
alexgarel
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
@Marc-AntoineA this is almost ok ! (just one mandatory thing to fix: the typing in search_get).
Thanks for this PR.
alexgarel
pushed a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- ## [1.4.0](v1.3.0...v1.4.0) (2024-07-25) ### Features * add default images for products without image in off.html [#208](#208) ([#220](#220)) ([e4456f3](e4456f3)) * add loader in search-results ([#209](#209)) ([0ee92b5](0ee92b5)) * be able to create scatter plots ([#189](#189)) ([92e1c1b](92e1c1b)) * hide chart when search is not launched ([#214](#214)) ([468a4c6](468a4c6)) * update count and refacto code with Signal ([#203](#203)) ([9fbec21](9fbec21)) ### Bug Fixes * move docs and fix content ([#215](#215)) ([2bc06c3](2bc06c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enrich the API to not only display bar charts but also scatter plots.
Screenshot