Re-introduce python installation #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a872e87. I misread the conditional chain and thought that the original code was only installing python for old Ubuntu versions. But it was just choosing the right python version depending on the Ubuntu version. We can now assume Python 3 and simplify the check.
rioug
reviewed
Jan 12, 2025
| - name: Install python | ||
| become: yes | ||
| raw: | | ||
| test -e /usr/bin/python || ( |
There was a problem hiding this comment.
Should we also test for /usr/bin/python3 ? we could skip the install if already there ?
There was a problem hiding this comment.
Currently, we depend on that symlink:
ofn-install/inventory/group_vars/all.yml
Lines 410 to 411 in e1c5181
But we could experiment with removing that config. I would expect Ansible to be clever enough to find any python on the machine.
rioug
approved these changes
Jan 14, 2025
dacook
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a872e87.
I misread the conditional chain and thought that the original code was only installing python for old Ubuntu versions. But it was just choosing the right python version depending on the Ubuntu version. We can now assume Python 3 and simplify the check.