Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default redis instance #988

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

rioug
Copy link
Contributor

@rioug rioug commented Jan 14, 2025

While looking at setting monitoring for all redis instances, I noticed a some of our prod instances don't have the default redis instances. That means we can't update the ActionCable configuration to use said instance as proposed here openfoodfoundation/openfoodnetwork#13072

According to the documentation redis should be enable/start automatically but it appears to not always be the case.
This PR add a new role to make sure the default instance of redis is enable and running when provisioning a server.

rioug added 2 commits January 15, 2025 10:24
The default redis instance should be automatically enabled/started
after install, but it does not always seem to happen.
It looks like it was missed in this clean up :
openfoodfoundation@28193ef
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, although it seems like something that should be handled by the galaxy role.

It might be easy enough to contribute: https://github.com/libre-ops/multi_redis/blob/main/tasks/main.yml

But for now, this does the job 👍

@mkllnk mkllnk merged commit 6d6e333 into openfoodfoundation:master Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants