Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on CI with LXC container #989

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Jan 15, 2025

We were running provisioning and deploy through a local connection on the Github runner itself. But when we upgrade to Ubuntu 22 and higher, that fails because of the permissions within the Github Actions container. So I decided to use a lightweight container which I've been using in development as well.

Now we are independent of the Github images and we could even run the tests against multiple Ubuntu versions in parallel.

The LXC setup took a little bit longer but not much:

  • Old local setup: 17m
  • LXC setup: 19m

@mkllnk mkllnk self-assigned this Jan 15, 2025
@mkllnk mkllnk marked this pull request as draft January 15, 2025 23:09
@mkllnk mkllnk marked this pull request as ready for review January 15, 2025 23:49
Copy link
Contributor

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one !

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dacook dacook merged commit a91ec3e into openfoodfoundation:master Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants