-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump redis from 4.8.1 to 5.0.8 #11698
Conversation
Something we've previously seen only on production is now showing up in testing. Much better this way:
This is an open blocking issue for now: |
We also see a new error which has been fixed in another branch:
|
Bumps [redis](https://github.com/redis/redis-rb) from 4.8.1 to 5.0.8. - [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md) - [Commits](redis/redis-rb@v4.8.1...v5.0.8) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
f4a806d
to
328904a
Compare
The hiredis client was praised as being faster parsing bulk responses but it seems to have multiple issues now: - The redis release 5.0 moved hiredis support to another gem. - I tried the hiredis-client gem and it raised errors. - There are claims of worse performance of hiredis [1]. - Maintenance responsiveness has been questioned [2]. Using the default redis driver seems to work fine though. [1]: https://discuss.rubyonrails.org/t/hiredis-does-not-support-ssl-action-cable/75945 [2]: redis/hiredis#655
1737494
to
687176c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, less custom config hopefully means less issues in the long run!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Bumps redis from 4.8.1 to 5.0.8.
Changelog
Sourced from redis's changelog.
... (truncated)
Commits
2b183ad
Release 5.0.8230a5c4
Merge pull request #1227 from supercaracal/add-sharded-pubsub-support54e6a7e
Add sharded Pub/Sub support for clusterccdf15f
Merge pull request #1226 from supercaracal/support-transaction-for-cluster-cl...dda95f8
Support transactions for cluster clientc888c74
Merge pull request #1225 from afinzel/masterad0f30b
Update default timeout docs8e9183a
Update sentinel auth with explicit kwargs (#1221)01de51a
Merge pull request #1222 from supercaracal/fix-clusterea4d04a
Fix redis-clustering gem to pass the test with latest dependenciesYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)