Remove stripe decorator #8071
Closed
Remove stripe decorator #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8071 +/- ##
===========================================
- Coverage 93.21% 23.10% -70.12%
===========================================
Files 645 571 -74
Lines 18161 20861 +2700
===========================================
- Hits 16928 4819 -12109
- Misses 1233 16042 +14809
Continue to review full report at Codecov.
|
If the response has `nil` for `gateway_payment_profile_id` or `gateway_customer_profile_id`, but we've already stored those, don't overwrite the existing values
andrewpbrett
force-pushed
the
remove-stripe-decorator
branch
4 times, most recently
from
c79e07c to
6807d86
Compare
andrewpbrett
force-pushed
the
remove-stripe-decorator
branch
from
6807d86 to
0f3bcc6
Compare
|
@Matt-Yorkley do you know if we still need this PR after your refactoring? In any case, shall this PR be closed? |
|
The original issue #7326 is still valid, the decorator is still in place. I think we can close this PR for now though 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #7326
As part of refactoring and proactively debugging our Stripe integration, we'd like to stay as close as possible to the officially supported ActiveMerchant code.
What should we test?
This will need a thorough testing of all payment areas
Release notes
Removed the Stripe decorator to realign OFN with the officially supported ActiveMerchant code
Changelog Category: Technical changes
Dependencies
Documentation updates