Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3855 - Move files to s3 bucket #3978

Merged
merged 35 commits into from
Jan 20, 2025
Merged

3855 - Move files to s3 bucket #3978

merged 35 commits into from
Jan 20, 2025

Conversation

sorja
Copy link
Contributor

@sorja sorja commented Sep 27, 2024 •
edited
Loading

  • check migration step is exists query
  • Check public migration OR migration-step to alter DDL correctly

implementation:

  • create a bucket to s3
  • implement new service FileStorage to write and read files
  • remove column file from public.file

todo:

  • src/server/repository/public/ddl/getCreatePublicSchemaDDL.ts update public.file with public migration
  • investigate if we want to remove public.file

todo/check:

  • upload and view avatar
  • upload and view file from Links and repository
  • upload and view file from EditorWYSIWYG

sorja and others added 17 commits August 30, 2024 13:57
@sorja sorja changed the title 3855 move files to s3 bucket 3855 - Move files to s3 bucket Sep 27, 2024
@mergify mergify bot mentioned this pull request Sep 27, 2024
Closed
4 tasks
@sorja sorja self-assigned this Oct 1, 2024
@sorja
Copy link
Contributor Author

sorja commented Jan 10, 2025

  • [ ] Write a script to test all files

sorja and others added 5 commits January 13, 2025 15:44
@sorja
3855 - Check all files exist in S3 (#4207)
79058bd 
* 3855 - Add Arrays.chunk

* 3855 - Add env var: authCookie

* 3855 - Update test

* 3855 - Remove authCookie env var
@sorja
Merge branch 'development' into 3855-move-files-to-s3-bucket
04690b7
@sorja
3855 - Separate upload files (#4215)
cf884fb 
* rename testAllFilesUploaded

* 3855 - Separate file uploading

* 3855 - Move s3Files under tools
@sorja
3855 - Include public.file in db copy (#4217)
b2e7f07
@minotogna
Merge branch 'development' into 3855-move-files-to-s3-bucket
b362c30
minotogna
minotogna reviewed Jan 16, 2025
View reviewed changes
src/server/api/file/get.ts Show resolved Hide resolved
src/server/controller/cycleData/repository/getManyFiles.ts Outdated Show resolved Hide resolved
src/tools/uploadToS3/index.ts Outdated Show resolved Hide resolved
@minotogna minotogna marked this pull request as ready for review January 16, 2025 10:14
minotogna
minotogna requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@minotogna minotogna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing a repository item doesn't remove the file from the s3 bucket. it should.

@sorja sorja force-pushed the 3855-move-files-to-s3-bucket branch from eccec2e to 022ea0c Compare January 17, 2025 14:45
@mergify mergify bot merged commit 3828384 into development Jan 20, 2025
5 checks passed
@mergify mergify bot deleted the 3855-move-files-to-s3-bucket branch January 20, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minotogna minotogna minotogna approved these changes

Assignees

@sorja sorja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorja @minotogna