Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate the performances of the lib #455

Open
12rambau opened this issue Apr 28, 2022 · 3 comments
Open

evaluate the performances of the lib #455

12rambau opened this issue Apr 28, 2022 · 3 comments
Labels
cd/ci relative to CI quality generated by code climate

Comments

@12rambau
Copy link
Member

this can be extended to the applications notebooks.

I'm curious to know if we can improve their performances (they seems drastically long to load).

A nice heuristic to keep in mind:

  • make it work ✔️
  • make it nice ✔️
  • make it fast 🎯

food for thought on testing both the lib loading and the notebooks:
running a notebook as a python script
the tuna profiling lib

@12rambau 12rambau added cd/ci relative to CI quality generated by code climate labels Apr 28, 2022
12rambau added a commit that referenced this issue May 4, 2022
@12rambau 12rambau mentioned this issue May 4, 2022
3 tasks
@12rambau 12rambau reopened this May 31, 2022
@12rambau
Copy link
Member Author

12rambau commented Sep 4, 2023

@dfguerrerom I checked the lib and it takes 18s to load in tuna which is simply huuuuuuuge. To make you realize how long it is:

  • pandas takes 0.5s
  • vuetify takes 6s
  • ipywidgets takes 5s

there is clearly something wrong. I have 2 guesses:

  • traitlets is an expensive lib and creating javascript/python binding cost a lot, we should revieww more carefuly when we use one.
  • we have an abstraction debt that is over the roof as we completely override the ipyvuetify lib that is already taking a lot of time to load. I think we should only rely on pure vuetify widgets and use an accessor to add extra functionality. I'll make a PR to ipyvue to integrate an equivalent to get_children.

@dfguerrerom
Copy link
Collaborator

Yes, the loading time is extremely slow. I agree with the second point of your guesses, that would reduce an important step on our side, so thumbs up for that one.

@12rambau
Copy link
Member Author

12rambau commented Sep 8, 2023

I also found on the web that complex type hints are actually slowing down Python code unless you use the annotation package (https://stackoverflow.com/questions/61544854/from-future-import-annotations). We have a lot of them, we should start using it everywhere untli it becomes the default behavior (not even in 3.11).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cd/ci relative to CI quality generated by code climate
Projects
None yet
Development

No branches or pull requests

2 participants