Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update_progress accept values >1 #646

Merged
merged 1 commit into from
Dec 11, 2022
Merged

fix: update_progress accept values >1 #646

merged 1 commit into from
Dec 11, 2022

Conversation

12rambau
Copy link
Member

@12rambau 12rambau commented Nov 29, 2022

  • by default ùpdate_progress continues to refuse values >1 (no regression)
  • the user can select a different total parameter for tqdm and then the value should only be <total

Fix #562

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #646 (dc7fd95) into main (8a8196e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #646   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files          36       36           
  Lines        3911     3912    +1     
=======================================
+ Hits         3623     3624    +1     
  Misses        288      288           
Impacted Files Coverage Δ
sepal_ui/sepalwidgets/alert.py 98.02% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@12rambau 12rambau marked this pull request as ready for review November 30, 2022 11:04
@12rambau
Copy link
Member Author

I need this PR to be merged for the conda release. I'm overpassing review checks. Don't hesitate to reach in the issues if needed

@12rambau 12rambau merged commit 672ebdd into main Dec 11, 2022
@12rambau 12rambau deleted the progress branch December 11, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow other values for progress
1 participant