Bugfix of true type font copying #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bers of the class
…mbers of the class
|
If you've tested this and the appveyor/travis tests pass, this seems pretty solid from a code-review standpoint. Thanks for the contribution. |
| texAtlas = mom.texAtlas; | ||
| stringQuads = mom.stringQuads; |
There was a problem hiding this comment.
can you change this to stringQuads = std::move(mom::stringQuads)
|
hey, thanks! i've added a couple of comments, you could also just remove those lines since that variable is just a cache and not copying/moving it shouldn't have any effect |
|
Done. Since you said is just a cache, I removed it from all constructors and it seems to work. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem, described in issue #5123, was caused by the copy/assignment constructors of the ofTrueTypeFont that did not copy all the members to the target.
Since my familiarity with openFrameworks and C++ knowledge are limited, please check if my additions are relevant/do not have any side effects.
The bug was apparently fixed and did not cause any visible side effects. Tested on the small sample of code I've shown in the issue and on few examples (such as graphics/fontShapesExample and graphics/fontsExample).