Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧(docker) restrict what is copied in the production image #1413

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

lunika
Copy link
Member

@lunika lunika commented Mar 3, 2022

Purpose

We analyzed the production image to detect if files are copied in it and
are not needed to run in production. We updated the .dockerignore file
to ignore files used in the development process. In the Dockerfile, in
the final layer we only copy the backend application. The front sources
are not needed anymore, they have been built and are copied in the
static repository.

Proposal

  • restrict what is copied in the production image

@lunika lunika requested review from kernicPanel and qbey March 3, 2022 14:07
@lunika lunika self-assigned this Mar 3, 2022
Copy link

@qbey qbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleaning :)

We analyzed the production image to detect if files are copied in it and
are not needed to run in production. We updated the .dockerignore file
to ignore files used in the development process. In the Dockerfile, in
the final layer we only copy the backend application. The front sources
are not needed anymore, they have been built and are copied in the
static repository.
@lunika lunika force-pushed the Docker-enhancement branch from 32047ab to f184cdd Compare March 4, 2022 15:41
@lunika lunika merged commit c547683 into master Mar 4, 2022
@lunika lunika deleted the Docker-enhancement branch March 4, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants