🐛(frontend) fix issues test staging #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
issue/anthony/fix-issues-test-staging
branch
3 times, most recently
from
f3a686e to
8167a02
Compare
With the classroom link for students, we provided an epurated interface with only the necessary elements so the student couldn't change the language. We added a language selector to allow students to change the language of the website.
In order to do the transition to the cunningham design system, we replace the grommet Anchor component.
Remove the blocking error "Missing shared live session urls during a sharing" on the student side when a shared document is deleted during a live session.
When displayed inside an iframe, the attendance block was not displayed correctly. This commit fixes the issue by adding a margin to the attendance block.
AntoLC
force-pushed
the
issue/anthony/fix-issues-test-staging
branch
from
8167a02 to
adbd563
Compare
kernicPanel
approved these changes
Nov 17, 2023
lunika
approved these changes
Nov 17, 2023
| 'The label of the button for stopping to allow students to download the media.', | ||
| id: 'component.AllowedDownloadButton.buttonLabel', | ||
| 'Label of the toggle allowing to download the support share by the instructor', | ||
| id: 'component.StartSharingButton.labelToggleAllowDownloadSupport', |
There was a problem hiding this comment.
as you rename this component, you should change all the id for all messages. And I think it should not be StartSharingButton but ToggleDownload.
Depend the cases, it was complicated to keep on 1 line all the options that we wanted to propose to the user. We refacto the layout and transformed the buttons into toggle buttons to make it more clear and easier to display.
The attendance duration could be confusing, we humanize it.
The select width was too small because the label was in absolute position. Now the label is in relative position and the select width is relative of the label.
The deposit files was not displayed correctly on the mobile view. This commit improve the responsive.
AntoLC
force-pushed
the
issue/anthony/fix-issues-test-staging
branch
from
adbd563 to
62562f3
Compare
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The tests in staging highlighted some errors, this PR will fix the errors found.
The task number is the corresponding of the Trello tasks.
Proposal
Visual
Task 5 : 🚸(lib_classroom) humanize duration attendance
Task 9 : ♻️(frontend) refacto widgets SharedLiveMedia
scrnli_11_16_2023_10-48-19.AM.webm
Task 10 : 🐛(lib-common) fix select width
Task 11 : 📱(lti) improve the responsive on the student deposite file
scrnli_11_16_2023_2-18-39.PM.webm